Revert "Handle pricing api change in aws-sdk-go 1.44.46 #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @AustinSiu @bwagner5 |
digocorbellini
pushed a commit
to digocorbellini/amazon-ec2-instance-selector
that referenced
this pull request
Jul 21, 2022
digocorbellini
added a commit
that referenced
this pull request
Jul 26, 2022
* created sorting system based on json pathing * incorporated sorting system into CLI * added shorthand sorting fields * Revert "Handle pricing api change in aws-sdk-go 1.44.46 (#145) * Revert "Handle pricing api change in aws-sdk-go 1.44.46 (#140)" This reverts commit cec208c. * Update aws-sdk-go to v1.44.59 * added sorting example and new help printout to readme * added jsonpath library license to third party licenses * changed sorting to use sort.Slice() * removed need for $ in json path * shortened sort-by flag description and updated readme * early sort return for empty and 1 element lists * added sorter tests * fixed typos * reduced scope of if statement in main Co-authored-by: Brandon Wagner <[email protected]> * simplified call to sort instances * modified tests for new sorting interface * fixed comment typo * refactored sorting keys map Co-authored-by: Rodrigo Okamoto <[email protected]> Co-authored-by: Ciprian Hacman <[email protected]> Co-authored-by: Brandon Wagner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Reverts #140, because the price API change was reverted in aws/aws-sdk-go#4480.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.