Skip to content

Conversation

bwagner5
Copy link
Contributor

Issue #, if available:
N/A

Description of changes:
allow-list and deny-list were the first two regex and more complex data types introduced to the filters struct. encoding/json does not properly return the string representation of regexp.Regexp which breaks the verbose filter output since it used json.Marshal. This PR implements a MarshalIndent on the Filters type.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bwagner5 bwagner5 requested a review from haugenj June 23, 2020 18:24
@codecov-commenter
Copy link

Codecov Report

Merging #17 into master will increase coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   89.46%   89.66%   +0.20%     
==========================================
  Files           7        7              
  Lines         826      842      +16     
==========================================
+ Hits          739      755      +16     
  Misses         57       57              
  Partials       30       30              
Impacted Files Coverage Δ
pkg/selector/types.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eabf2f5...1e8394b. Read the comment docs.

Copy link
Contributor

@haugenj haugenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bwagner5 bwagner5 merged commit eab69ea into aws:master Jun 23, 2020
@bwagner5 bwagner5 deleted the filter-marshal branch July 15, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants