Skip to content

Conversation

@bwagner5
Copy link
Contributor

Issue #, if available:
N/A

Description of changes:
The vcpus-to-memory-ratio was computed to 2 decimal places, but this isn't lenient enough for old instance types that have odd ratios. This change uses the ceiling so that old instance types are returned for ratios that are close enough.

This change also fixes some copy and paste errors in the test failure output.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bwagner5 bwagner5 requested a review from haugenj June 23, 2020 18:27
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2020

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.67%. Comparing base (eabf2f5) to head (93e0854).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   89.46%   89.67%   +0.21%     
==========================================
  Files           7        7              
  Lines         826      843      +17     
==========================================
+ Hits          739      756      +17     
  Misses         57       57              
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bwagner5 bwagner5 requested a review from haugenj June 23, 2020 19:05
Copy link
Contributor

@haugenj haugenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🥇

@bwagner5 bwagner5 merged commit 3e75148 into aws:master Jun 23, 2020
@bwagner5 bwagner5 deleted the ratio-ceiling branch July 15, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants