Skip to content

Conversation

bwagner5
Copy link
Contributor

Issue #, if available:
N/A

Description of changes:

  • The singular AZ param was deprecated previously, but since we are pending a major release to include the ByteQuantity changes, we can remove the singular AZ handling in favor of the plural --availability-zones param.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2020

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.61%. Comparing base (acdbb43) to head (cd47c72).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   88.38%   88.61%   +0.22%     
==========================================
  Files           9        9              
  Lines        1068     1063       -5     
==========================================
- Hits          944      942       -2     
+ Misses         88       87       -1     
+ Partials       36       34       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bwagner5 bwagner5 requested a review from brycahta July 29, 2020 21:37
Copy link
Contributor

@brycahta brycahta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple other places:

@bwagner5
Copy link
Contributor Author

good catch once again! fixed

Copy link
Contributor

@brycahta brycahta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍🏼

pumped for the 2.0 launch party 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants