Skip to content

fix pricing api endpoint #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2021
Merged

fix pricing api endpoint #85

merged 1 commit into from
May 7, 2021

Conversation

bwagner5
Copy link
Contributor

@bwagner5 bwagner5 commented May 5, 2021 •
edited
Loading

Issue #, if available:
N/A

Description of changes:

  • Fix pricing client to use global endpoint since they do not offer regional endpoints
  • Use AWS ECR gallery rather than dockerhub for golang image to avoid dockerhub rate limiting
  • Run license test on PRs too since Github Actions automatically injects a read-only GITHUB_TOKEN in PR GA runs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bwagner5 bwagner5 mentioned this pull request May 5, 2021
Closed
@bwagner5 bwagner5 force-pushed the pricing-endpoint branch 2 times, most recently from 1e40aa1 to e3ad2aa Compare May 5, 2021 22:36
brycahta
brycahta reviewed May 6, 2021
View reviewed changes
Copy link
Contributor

@brycahta brycahta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use AWS ECR gallery rather than dockerhub
😍

Github Actions automatically injects a read-only GITHUB_TOKEN in PR GA runs

Could you clarify this? Are you just saying how GitHub Actions normally works since we provide GITHUB_TOKEN in the env block of ci.yaml ?

@bwagner5 bwagner5 force-pushed the pricing-endpoint branch 2 times, most recently from 5e6307a to 92b2115 Compare May 6, 2021 16:04
@bwagner5 bwagner5 force-pushed the pricing-endpoint branch from 92b2115 to 8f1284a Compare May 6, 2021 16:12
@bwagner5 bwagner5 merged commit 487b219 into aws:main May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@brycahta brycahta brycahta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bwagner5 @brycahta