-
Notifications
You must be signed in to change notification settings - Fork 640
Introduce ECS_PAUSE_LABELS env var to apply labels to pause container #4789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danehlim
reviewed
Nov 1, 2025
47d0aba to
282864b
Compare
Contributor
|
Thank you @shogondo for your contribution with this pull request! I have made some updates to this pull request to address the comments I raised and will get this pull request reviewed by another member of our team. |
danehlim
reviewed
Nov 1, 2025
282864b to
660e68b
Compare
harishxr
reviewed
Nov 5, 2025
harishxr
reviewed
Nov 5, 2025
harishxr
previously approved these changes
Nov 5, 2025
TheanLim
reviewed
Nov 6, 2025
a9ccd8e to
51690e6
Compare
51690e6 to
348036c
Compare
harishxr
approved these changes
Nov 7, 2025
TheanLim
approved these changes
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change introduces new environment variable
ECS_PAUSE_LABELS. This can be used to apply custom labels to pause containers. Related issue: #4427.Implementation details
Changes:
task.DockerConfigto apply custom labels to pause containers if theECS_PAUSE_LABELSprovided.ECS_PAUSE_LABELScan be specified with JSON format, similar toECS_AGENT_LABELSECS_PAUSE_LABELSisn't provided, does nothing.ECS_PAUSE_LABELSis invalid format, just ignores it.Testing
Tested manually on an EC2 container instance.
Config:
Before:
After:
New tests cover the changes: yes
Description for the changelog
Enhancement: Add new environment variable
ECS_PAUSE_LABELSto apply custom labels to pause containersAdditional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.