chore: add a table for exception codes #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/using-the-jdbc-wrapper/using-plugins/UsingTheFailoverPlugin.md
Outdated
Show resolved
Hide resolved
crystall-bitquill
approved these changes
Aug 10, 2022
sergiyvamz
reviewed
Aug 10, 2022
| ## Failover Exception Codes | ||
|
|
||
| | Exceptions | Is the connection valid? | Can the connection be reused? | Has the session state changed? | Does the session need to be reconfigured? | Does the last statement need to be re-executed | Does the transaction need to be restarted | | ||
| | ------------------------------------------ | ------------------------ | ----------------------------- | ------------------------------ | ----------------------------------------- | ---------------------------------------------- | ----------------------------------------- | |
Contributor
There was a problem hiding this comment.
If we need to add more columns/questions then the table gets wider that makes it unreadable. Does it makes sense to pivot the table?
Contributor
Author
There was a problem hiding this comment.
I tried to transpose the table but I think this version is more readable. If we do decide to add columns I think we should look for a better representation than using table.
sergiyvamz
reviewed
Aug 10, 2022
docs/using-the-jdbc-wrapper/using-plugins/UsingTheFailoverPlugin.md
Outdated
Show resolved
Hide resolved
sergiyvamz
reviewed
Aug 10, 2022
docs/using-the-jdbc-wrapper/using-plugins/UsingTheFailoverPlugin.md
Outdated
Show resolved
Hide resolved
sergiyvamz
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
chore: add a table for exception codes
Additional Reviewers
@sergiyvamz