feat(toolkit-lib): add support for AWS::DynamoDB::GlobalTable and AWS::Lambda::Url Arn attributes #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…::Lambda::Url Arn attributes - Add AWS::DynamoDB::GlobalTable to RESOURCE_TYPE_ATTRIBUTES_FORMATS - Add AWS::Lambda::Url to RESOURCE_TYPE_ATTRIBUTES_FORMATS - Add comprehensive test cases for both GlobalTable and Lambda URL Arn attributes in hotswap - Fixes issue where cdk watch would fail with unsupported resource attributes Fixes #35688
pedrolourencoribeiro
requested a deployment
to
integ-approval
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the
Arnattribute ofAWS::DynamoDB::GlobalTableandAWS::Lambda::Urlresources in CDK hotswap deployments.Changes Made
AWS::DynamoDB::GlobalTabletoRESOURCE_TYPE_ATTRIBUTES_FORMATSinevaluate-cloudformation-template.tsAWS::Lambda::UrltoRESOURCE_TYPE_ATTRIBUTES_FORMATSinevaluate-cloudformation-template.tsstate-machine-hotswap-deployments.test.tsto verify both functionalitiesstdSlashResourceArnFmtfunction for consistent ARN formattingTesting
Fixes
Fixes #35688
Example
Before this fix, using
cdk watchwith stacks containing DynamoDB GlobalTable or Lambda URL resources would fail with:We don't support attributes of the 'AWS::DynamoDB::GlobalTable' resource. This is a CDK limitation.
We don't support attributes of the 'AWS::Lambda::Url' resource. This is a CDK limitation.
After this fix,
cdk watchworks correctly with both resource types.