fix: CMake Fixes to Make it Compatible with Latest Aws-c-common #812
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Hi, I am from the Common Runtime team and we own https://github.com/awslabs/aws-c-common. We recently did some cleanup in CMake, in aws-c-common at awslabs/aws-c-common#1178. This broke this repository because it was relying on aws-c-common to set
LIBRARY_DIRECTORY
andRUNTIME_DIRECTORY
, which aws-c-common no longer does. This PR updates aws-encryption-sdk-c to now use the official CMake variables like aws-c-common.Changes:
CMAKE_INSTALL_LIBDIR
,CMAKE_INSTALL_BINDIR
,CMAKE_INSTALL_INCLUDEDIR
LIBRARY_DIRECTORY,RUNTIME_DIRECTORY)include(GNUInstallDirs)
on all platformsGNUInstallDirs
wasn't safe for Windows and Apple, but despite its name, it's fine. Professional CMake says:We can improve the CMake further like we did in aws-c-common, which will also fix #811, but I have decided to keep this PR simple, so that it is easier to review and merge.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: