Skip to content

Conversation

@M00nF1sh
Copy link
Contributor

@M00nF1sh M00nF1sh commented Mar 11, 2020

Add an AppMesh Addon.
which will configure node role iam permissions and will install AppMesh Controller/Injector from helm charts (we use it to test helm charts as well 🤣 )
configurable options:

  • AWS_K8S_TESTER_EKS_ADD_ON_APP_MESH_ENABLE: true/false (whether enable this addOn)
  • AWS_K8S_TESTER_EKS_ADD_ON_APP_MESH_NAMESPACE: ... (where to install controllers, defaults to appmesh-system)
  • AWS_K8S_TESTER_EKS_ADD_ON_APP_MESH_CONTROLLER_IMAGE: imageRepo:imageTag (defaults the one in helm chart)
  • AWS_K8S_TESTER_EKS_ADD_ON_APP_MESH_INJECTOR_IMAGE: imageRepo:imageTag (defaults the one in helm chart)

Test done:

rm -rf test-prod*
AWS_K8S_TESTER_EKS_REGION=us-west-2 \
AWS_K8S_TESTER_EKS_PARAMETERS_VERSION=1.14 \
AWS_K8S_TESTER_EKS_ADD_ON_MANAGED_NODE_GROUPS_ENABLE=true \
AWS_K8S_TESTER_EKS_ADD_ON_APP_MESH_ENABLE=true \
./bin/aws-k8s-tester-de1e65c500d1-darwin-amd64 eks create config -p test-prod.yaml && cat test-prod.yaml
./bin/aws-k8s-tester-de1e65c500d1-darwin-amd64 eks create cluster -p test-prod.yaml
./bin/aws-k8s-tester-de1e65c500d1-darwin-amd64 eks delete cluster -p test-prod.yaml

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

k8s.io/apimachinery => k8s.io/apimachinery v0.0.0-20190817020851-f2f3a405f61d
k8s.io/client-go => k8s.io/client-go v0.0.0-20190918200256-06eb1244587a
)
replace k8s.io/client-go => k8s.io/client-go v0.0.0-20190918200256-06eb1244587a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great :)

Copy link
Contributor Author

@M00nF1sh M00nF1sh Mar 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go modules is a hell..i wasted 1 hour try to add cli-runtime and make it compatible with others. 😄

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants