Switch pub static values to pub const

.github/workflows/tests.yml

@@ -160,7 +160,7 @@ jobs:
     strategy:
       matrix:
         args:
-          -
+          - ''
           - --release
         features:
           - --features asan

aws-lc-rs/src/aead/quic.rs

@@ -120,21 +120,21 @@ impl PartialEq for Algorithm {
 impl Eq for Algorithm {}
 
 /// AES-128.
-pub static AES_128: Algorithm = Algorithm {
+pub const AES_128: Algorithm = Algorithm {
     key_len: 16,
     init: SymmetricCipherKey::aes128,
     id: AlgorithmID::AES_128,
 };
 
 /// AES-256.
-pub static AES_256: Algorithm = Algorithm {
+pub const AES_256: Algorithm = Algorithm {
     key_len: 32,
     init: SymmetricCipherKey::aes256,
     id: AlgorithmID::AES_256,
 };
 
 /// `ChaCha20`.
-pub static CHACHA20: Algorithm = Algorithm {
+pub const CHACHA20: Algorithm = Algorithm {
     key_len: 32,
     init: SymmetricCipherKey::chacha20,
     id: AlgorithmID::CHACHA20,

aws-lc-rs/src/cipher.rs

@@ -374,21 +374,21 @@ pub struct Algorithm {
 }
 
 /// AES 128-bit cipher
-pub static AES_128: Algorithm = Algorithm {
+pub const AES_128: Algorithm = Algorithm {
     id: AlgorithmId::Aes128,
     key_len: AES_128_KEY_LEN,
     block_len: AES_BLOCK_LEN,
 };
 
 /// AES 192-bit cipher
-pub static AES_192: Algorithm = Algorithm {
+pub const AES_192: Algorithm = Algorithm {
     id: AlgorithmId::Aes192,
     key_len: AES_192_KEY_LEN,
     block_len: AES_BLOCK_LEN,
 };
 
 /// AES 256-bit cipher
-pub static AES_256: Algorithm = Algorithm {
+pub const AES_256: Algorithm = Algorithm {
     id: AlgorithmId::Aes256,
     key_len: AES_256_KEY_LEN,
     block_len: AES_BLOCK_LEN,

aws-lc-rs/src/digest/sha.rs

@@ -60,7 +60,7 @@ const DIGEST_MAX_INPUT_LEN: u64 = u64::MAX;
 ///
 /// [FIPS 180-4]: http://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.180-4.pdf
 #[allow(deprecated)]
-pub static SHA1_FOR_LEGACY_USE_ONLY: Algorithm = Algorithm {
+pub const SHA1_FOR_LEGACY_USE_ONLY: Algorithm = Algorithm {
     output_len: SHA1_OUTPUT_LEN,
     chaining_len: SHA1_OUTPUT_LEN,
     block_len: SHA1_BLOCK_LEN,
@@ -75,7 +75,7 @@ pub static SHA1_FOR_LEGACY_USE_ONLY: Algorithm = Algorithm {
 ///
 /// [FIPS 180-4]: http://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.180-4.pdf
 #[allow(deprecated)]
-pub static SHA224: Algorithm = Algorithm {
+pub const SHA224: Algorithm = Algorithm {
     output_len: SHA224_OUTPUT_LEN,
 
     // The chaining length is equivalent to the length before truncation.
@@ -93,7 +93,7 @@ pub static SHA224: Algorithm = Algorithm {
 ///
 /// [FIPS 180-4]: http://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.180-4.pdf
 #[allow(deprecated)]
-pub static SHA256: Algorithm = Algorithm {
+pub const SHA256: Algorithm = Algorithm {
     output_len: SHA256_OUTPUT_LEN,
     chaining_len: SHA256_OUTPUT_LEN,
     block_len: SHA256_BLOCK_LEN,
@@ -108,7 +108,7 @@ pub static SHA256: Algorithm = Algorithm {
 ///
 /// [FIPS 180-4]: http://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.180-4.pdf
 #[allow(deprecated)]
-pub static SHA384: Algorithm = Algorithm {
+pub const SHA384: Algorithm = Algorithm {
     output_len: SHA384_OUTPUT_LEN,
 
     // The chaining length is equivalent to the length before truncation.
@@ -126,7 +126,7 @@ pub static SHA384: Algorithm = Algorithm {
 ///
 /// [FIPS 180-4]: http://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.180-4.pdf
 #[allow(deprecated)]
-pub static SHA512: Algorithm = Algorithm {
+pub const SHA512: Algorithm = Algorithm {
     output_len: SHA512_OUTPUT_LEN,
     chaining_len: SHA512_OUTPUT_LEN,
     block_len: SHA512_BLOCK_LEN,
@@ -141,7 +141,7 @@ pub static SHA512: Algorithm = Algorithm {
 ///
 /// [FIPS 180-4]: http://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.180-4.pdf
 #[allow(deprecated)]
-pub static SHA512_256: Algorithm = Algorithm {
+pub const SHA512_256: Algorithm = Algorithm {
     output_len: SHA512_256_OUTPUT_LEN,
     chaining_len: SHA512_OUTPUT_LEN,
     block_len: SHA512_BLOCK_LEN,
@@ -156,7 +156,7 @@ pub static SHA512_256: Algorithm = Algorithm {
 ///
 /// [FIPS 202]: https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.202.pdf
 #[allow(deprecated)]
-pub static SHA3_256: Algorithm = Algorithm {
+pub const SHA3_256: Algorithm = Algorithm {
     output_len: SHA3_256_OUTPUT_LEN,
     chaining_len: SHA3_256_OUTPUT_LEN,
     block_len: SHA3_256_BLOCK_LEN,
@@ -171,7 +171,7 @@ pub static SHA3_256: Algorithm = Algorithm {
 ///
 /// [FIPS 202]: https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.202.pdf
 #[allow(deprecated)]
-pub static SHA3_384: Algorithm = Algorithm {
+pub const SHA3_384: Algorithm = Algorithm {
     output_len: SHA3_384_OUTPUT_LEN,
     chaining_len: SHA3_384_OUTPUT_LEN,
     block_len: SHA3_384_BLOCK_LEN,
@@ -186,7 +186,7 @@ pub static SHA3_384: Algorithm = Algorithm {
 ///
 /// [FIPS 202]: https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.202.pdf
 #[allow(deprecated)]
-pub static SHA3_512: Algorithm = Algorithm {
+pub const SHA3_512: Algorithm = Algorithm {
     output_len: SHA3_512_OUTPUT_LEN,
     chaining_len: SHA3_512_OUTPUT_LEN,
     block_len: SHA3_512_BLOCK_LEN,

aws-lc-rs/src/hkdf.rs

@@ -59,17 +59,16 @@ impl Algorithm {
 }
 
 /// HKDF using HMAC-SHA-1. Obsolete.
-pub static HKDF_SHA1_FOR_LEGACY_USE_ONLY: Algorithm =
-    Algorithm(hmac::HMAC_SHA1_FOR_LEGACY_USE_ONLY);
+pub const HKDF_SHA1_FOR_LEGACY_USE_ONLY: Algorithm = Algorithm(hmac::HMAC_SHA1_FOR_LEGACY_USE_ONLY);
 
 /// HKDF using HMAC-SHA-256.
-pub static HKDF_SHA256: Algorithm = Algorithm(hmac::HMAC_SHA256);
+pub const HKDF_SHA256: Algorithm = Algorithm(hmac::HMAC_SHA256);
 
 /// HKDF using HMAC-SHA-384.
-pub static HKDF_SHA384: Algorithm = Algorithm(hmac::HMAC_SHA384);
+pub const HKDF_SHA384: Algorithm = Algorithm(hmac::HMAC_SHA384);
 
 /// HKDF using HMAC-SHA-512.
-pub static HKDF_SHA512: Algorithm = Algorithm(hmac::HMAC_SHA512);
+pub const HKDF_SHA512: Algorithm = Algorithm(hmac::HMAC_SHA512);
 
 /// General Salt length's for HKDF don't normally exceed 256 bits.
 /// We set the limit to something tolerable, so that the Salt structure can be stack allocatable.

aws-lc-rs/src/hmac.rs

@@ -133,19 +133,19 @@ impl Algorithm {
 }
 
 /// HMAC using SHA-1. Obsolete.
-pub static HMAC_SHA1_FOR_LEGACY_USE_ONLY: Algorithm = Algorithm(&digest::SHA1_FOR_LEGACY_USE_ONLY);
+pub const HMAC_SHA1_FOR_LEGACY_USE_ONLY: Algorithm = Algorithm(&digest::SHA1_FOR_LEGACY_USE_ONLY);
 
 /// HMAC using SHA-224.
-pub static HMAC_SHA224: Algorithm = Algorithm(&digest::SHA224);
+pub const HMAC_SHA224: Algorithm = Algorithm(&digest::SHA224);
 
 /// HMAC using SHA-256.
-pub static HMAC_SHA256: Algorithm = Algorithm(&digest::SHA256);
+pub const HMAC_SHA256: Algorithm = Algorithm(&digest::SHA256);
 
 /// HMAC using SHA-384.
-pub static HMAC_SHA384: Algorithm = Algorithm(&digest::SHA384);
+pub const HMAC_SHA384: Algorithm = Algorithm(&digest::SHA384);
 
 /// HMAC using SHA-512.
-pub static HMAC_SHA512: Algorithm = Algorithm(&digest::SHA512);
+pub const HMAC_SHA512: Algorithm = Algorithm(&digest::SHA512);
 
 /// An HMAC tag.
 ///

aws-lc-rs/src/pbkdf2.rs

@@ -120,25 +120,25 @@ pub struct Algorithm {
 }
 
 /// PBKDF2 using HMAC-SHA1.
-pub static PBKDF2_HMAC_SHA1: Algorithm = Algorithm {
+pub const PBKDF2_HMAC_SHA1: Algorithm = Algorithm {
     algorithm: hmac::HMAC_SHA1_FOR_LEGACY_USE_ONLY,
     max_output_len: MAX_USIZE32 * digest::SHA1_OUTPUT_LEN as u64,
 };
 
 /// PBKDF2 using HMAC-SHA256.
-pub static PBKDF2_HMAC_SHA256: Algorithm = Algorithm {
+pub const PBKDF2_HMAC_SHA256: Algorithm = Algorithm {
     algorithm: hmac::HMAC_SHA256,
     max_output_len: MAX_USIZE32 * digest::SHA256_OUTPUT_LEN as u64,
 };
 
 /// PBKDF2 using HMAC-SHA384.
-pub static PBKDF2_HMAC_SHA384: Algorithm = Algorithm {
+pub const PBKDF2_HMAC_SHA384: Algorithm = Algorithm {
     algorithm: hmac::HMAC_SHA384,
     max_output_len: MAX_USIZE32 * digest::SHA384_OUTPUT_LEN as u64,
 };
 
 /// PBKDF2 using HMAC-SHA512.
-pub static PBKDF2_HMAC_SHA512: Algorithm = Algorithm {
+pub const PBKDF2_HMAC_SHA512: Algorithm = Algorithm {
     algorithm: hmac::HMAC_SHA512,
     max_output_len: MAX_USIZE32 * digest::SHA512_OUTPUT_LEN as u64,
 };