Abstract fips entropy functions #1113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
reviewed
Jul 25, 2023
dkostic
previously approved these changes
Jul 25, 2023
torben-hansen
force-pushed
the
abstract_fips_entropy_functions
branch
from
45c7942 to
92ace6b
Compare
dkostic
previously approved these changes
Jul 25, 2023
dkostic
approved these changes
Jul 25, 2023
skmcgrail
approved these changes
Jul 25, 2023
nebeid
reviewed
Jul 27, 2023
|
|
||
| *additional_input_len = 0; | ||
|
|
||
| #if defined(FIPS_ENTROPY_SOURCE_JITTER_CPU) |
There was a problem hiding this comment.
Do we want to surround this with if defined(OPENSSL_URANDOM) as it was before?
There was a problem hiding this comment.
CRYPTO_sysrand should always be defined.
Merged
torben-hansen
added a commit
to torben-hansen/aws-lc
that referenced
this pull request
Sep 18, 2023
Abstract getting data from the configured entropy source of FIPS. Atm, the configured source is hard-coded in multiple workflows. This allows adding another source more easily. In addition, add some machinery to configure another source of build-time using the new define FIPS_ENTROPY_SOURCE_JITTER_CPU.
skmcgrail
pushed a commit
that referenced
this pull request
Sep 20, 2023
* Make PRNG model slightly more readable (#1079) The way the PRNG model is written looks more complicated than what is actually needed. Attempt to re-write it. This also makes it slightly easier to amend with future potential changes. * Remove CRNGT (#1112) CRNGT is not a requirement for FIPS 140-3. FIPS 140-2 Section 4.9.2 required the execution of the Continuous Randomness Number Generation Test (CRNGT). However, this requirement is not present in FIPS 140-3. In addition, later stages of FIPS 140-2 this test was not mandatory in all cases either (cf. FIPS 140-2 IG 9.8). Executing this test requires maintaining state, which inevitably introduces complexity. Given CRNGT is redundant with respect to compliance and really provides zero practical value (see, again, FIPS 140-2 IG 9.8), we axe it. * Abstract fips entropy functions (#1113) Abstract getting data from the configured entropy source of FIPS. Atm, the configured source is hard-coded in multiple workflows. This allows adding another source more easily. In addition, add some machinery to configure another source of build-time using the new define FIPS_ENTROPY_SOURCE_JITTER_CPU. * Implementation passive entropy (#1125) * Use passive entropy source method by default for FIPS build mode (#1188) Enables passive entropy method by default. In addition, adds a build-time config that can modify (at build-time) the entropy source method to CPU Jitter. * Kick CI bots * Kick CI bots, again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Description of changes:
Draft for now.
Abstract getting data from the configured entropy source of FIPS. Atm, the configured source is hard-coded in multiple workflows. This allows adding another source more easily.
In addition, add some machinery to configure another source of build-time using the new define
FIPS_ENTROPY_SOURCE_JITTER_CPU.Depends on: #1112.
Testing
This doesn't mutate any behaviour.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.