Skip to content

Conversation

@skmcgrail
Copy link
Member

@skmcgrail skmcgrail commented Jul 25, 2023

Description of changes:

Uses libabigail, which is available in Amazon Linux repositories for doing simple ABI Diffing between a pull request and the target branch to be merged into.

Notes

  • Currently just diffs the "standard" non-FIPS build, on x86-64 just to give some base coverage. We can expand this further at a later date.
  • The comparison is between the PR branch and the target branch. In a future revision I intend to also have it diff the PR branch to the last tagged release.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@skmcgrail skmcgrail force-pushed the abidiff branch 5 times, most recently from f8efd2a to 8d7ed3b Compare July 25, 2023 16:13
@skmcgrail skmcgrail changed the title ABI Diffing GitHub Action ABI Diff GitHub Action Jul 25, 2023
@skmcgrail skmcgrail marked this pull request as ready for review July 25, 2023 16:24
@skmcgrail skmcgrail requested a review from a team as a code owner July 25, 2023 16:24
@skmcgrail skmcgrail merged commit d8bf5f3 into aws:main Aug 8, 2023
@skmcgrail skmcgrail deleted the abidiff branch August 8, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants