Remove duplicate handling of OPENSSL_NO_ASM from CMake. #1149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Sikora <[email protected]>
justsmth
approved these changes
Aug 14, 2023
| endif() | ||
|
|
||
| if(OPENSSL_NO_ASM) | ||
| add_definitions(-DOPENSSL_NO_ASM) |
Contributor
There was a problem hiding this comment.
Yeah, the add_definitions(-DOPENSSL_NO_ASM) is redundant with the one on line 689 below.
skmcgrail
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Remove duplicate handling of
OPENSSL_NO_ASMfrom CMake.Call-outs:
OPENSSL_NO_ASMis handled a few lines below.It looks like this block was added as part of a bad cherry-pick/merge (compare the original commit boringssl@261ec612
with the cherry-pick aws-lc@1da6816b).
Testing:
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.