Fix build on gcc 4.8.3

[samuel40791765]

Description of changes:

We recently had a team reach out to us about our broken build on gcc 4.8.3. This is due to a bug that we've previously encountered in this commit: 6566103

Call-outs:

N/A

Testing:

We may have to add new CI to check for this, but it seems like this specific version is hard to find. We already have CI for gcc4.8.5.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

[justsmth]

I found a couple of other place we use intypes.h without this define. Should we add it to these as well?

• https://github.com/aws/aws-lc/blob/main/crypto/asn1/a_strex.c#L61
• https://github.com/aws/aws-lc/blob/main/crypto/asn1/posix_time.c#L19

[samuel40791765]

I found a couple of other place we use intypes.h without this define. Should we add it to these as well?

I noticed that too and was on the fence on that. I'm speculating that the bug is C++ specific. The team seems to have gotten the build working by just configuring this C++ file, and this fix also called out C++.

I'm still waiting for the team to test if this fix is sufficient enough for them. If not, we can add them to the C files as well. Just patching the C++ files works for them :)