crypto/pem: replace strncmp with CRYPTO_memcmp to fix -Wstring-compare error #2724
+7
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves #2719
Description of changes:
The code previously used:
if (strncmp(buf, "-----END ", 9) == 0) { ... }
If buf is a string with length < 9, or even just one character, GCC knows at compile time that this comparison can never return 0 (i.e. never match). So, GCC is giving out a warning here.. But because of
-Werror=string-compare
this warning is getting converted to an error which causing build failures in some platforms like s390x and riscv64Testing:
Build Logs:
To verify the build I ran the following test
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.