Missing default values for heartbeat in Helm chart

[koki-sato]

Describe the bug

Helm chart v0.26.0 does not have default values for heartbeat (added in #1116), so it is possible to generate a manifest that contains env with empty values.

Steps to reproduce

$ helm upgrade --dry-run --install aws-node-termination-handler \
  --namespace kube-system \
  --set enableSqsTerminationDraining=true \
  oci://public.ecr.aws/aws-ec2/helm/aws-node-termination-handler --version 0.26.0
...
---
# Source: aws-node-termination-handler/templates/deployment.yaml
apiVersion: apps/v1
kind: Deployment
spec:
  template:
    spec:
      containers:
        - name: aws-node-termination-handler
          env:
            - name: HEARTBEAT_INTERVAL
              value:
            - name: HEARTBEAT_UNTIL
              value:

Expected outcome

I think it's a good idea to set -1 as the default values for the helm chart according to the following:

aws-node-termination-handler/pkg/config/config.go

Lines 238 to 239 in e07cd85

	flag.IntVar(&config.HeartbeatInterval, "heartbeat-interval", getIntEnv(heartbeatIntervalKey, -1), "The time period in seconds between consecutive heartbeat signals. Valid range: 30-3600 seconds (30 seconds to 1 hour).")
	flag.IntVar(&config.HeartbeatUntil, "heartbeat-until", getIntEnv(heartbeatUntilKey, -1), "The duration in seconds over which heartbeat signals are sent. Valid range: 60-172800 seconds (1 minute to 48 hours).")

Application Logs

N/A

Environment

• NTH App Version: 1.24.0
• NTH Mode (IMDS/Queue processor): Queue processor
• OS/Arch:
• Kubernetes version:
• Installation method: Helm

[LikithaVemulapalli]

We have a fix in the latest release. Thank you