do not fail when scheduled event does not have end date #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-have information only.
bwagner5
force-pushed
the
end-time-optional
branch
from
09233b6 to
163c044
Compare
|
👍 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically closed because it has not had recent activity. Please feel free to resubmit the pull request if this has been in error. Thank you for your contributions. |
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
==========================================
+ Coverage 81.30% 81.33% +0.02%
==========================================
Files 8 8
Lines 765 766 +1
==========================================
+ Hits 622 623 +1
Misses 128 128
Partials 15 15
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
When processing scheduled maintenance events, do not fail when scheduled event does not have an end date. This information is not present for all events and is not utilized in the functionality of aws-node-termination-handler. It only serves as additional, nice-to-have information for logging/webhook msg purposes.
Issue #, if available:
#147
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.