Skip to content

Conversation

cjerad
Copy link
Contributor

@cjerad cjerad commented Dec 8, 2022

Issue #, if available:

Description of changes:

  • Replaced aws-sdk-go with aws-sdk-go-v2
  • Ran go mod tidy
  • Updated THIRD_PARTY_LICENSES.md

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cjerad cjerad requested a review from snay2 December 8, 2022 15:34
@cjerad cjerad marked this pull request as ready for review December 8, 2022 15:34
@cjerad cjerad requested a review from a team as a code owner December 8, 2022 15:34
Copy link
Contributor

@snay2 snay2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- github.com/aws/aws-node-termination-handler Unknown [Apache-2.0](https://github.com/aws/aws-node-termination-handler/blob/HEAD/LICENSE)
- github.com/aws/aws-sdk-go v1.38.55 [Apache-2.0](https://github.com/aws/aws-sdk-go/blob/v1.38.55/LICENSE.txt)
- github.com/aws/aws-sdk-go/internal/sync/singleflight v1.38.55 [BSD-3-Clause](https://github.com/aws/aws-sdk-go/blob/v1.38.55/internal/sync/singleflight/LICENSE)
- github.com/aws/aws-sdk-go-v2 v1.17.1 [Apache-2.0](https://github.com/aws/aws-sdk-go-v2/blob/v1.17.1/LICENSE.txt)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this file get updated automatically by some part of the build system?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not automatic. Have to run make third-party-licenses.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good too. Just as long as we don't have to do it manually. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants