Skip to content

Conversation

cjerad
Copy link
Contributor

@cjerad cjerad commented Jan 25, 2023

Issue #, if available:

Description of changes:

  • Add k8s 1.24 and 1.25 to version matrix
  • Omit PSPs when k8s version >= 1.25

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cjerad cjerad marked this pull request as ready for review January 26, 2023 15:58
@cjerad cjerad requested a review from a team as a code owner January 26, 2023 15:58
@cjerad cjerad requested a review from bwagner5 January 26, 2023 15:59
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! LGTM!

CLUSTER_NAME_BASE=$(uuidgen | cut -d'-' -f1 | tr '[:upper:]' '[:lower:]')
OVERRIDE_PATH=0
KIND_CONFIG_FILE=$SCRIPTPATH/kind-three-node-cluster.yaml
use_psp=false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also reviewed this yesterday, and my only question was "where are we originally setting use_psp?" Apparently it was right here all along, and I just scrolled past it. 😒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants