Skip to content

Conversation

@himani2411
Copy link
Contributor

Changing the PATH order we set for using the cfnbootstrap script we have installed in virtualenv rather than using default scripts

  • Adding Kitchen test

Develop -> #2729

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

enrico-usai
enrico-usai previously approved these changes May 21, 2024
@enrico-usai enrico-usai disabled auto-merge May 21, 2024 17:10
@himani2411 himani2411 enabled auto-merge (squash) May 22, 2024 11:21
…ave installed in virtualenv rather than using default scripts

* Adding Kitchen test to verify the PATH  used for cfn-init is the one we have installed using virtualenv
@himani2411 himani2411 merged commit 26a3c9d into aws:release-3.9 May 22, 2024
himani2411 pushed a commit to himani2411/aws-parallelcluster-cookbook that referenced this pull request May 27, 2024
…ipt we have installed in virtualenv rather than using default scripts (aws#2730)"

This reverts commit 26a3c9d.
himani2411 added a commit that referenced this pull request May 27, 2024
* [Bug] Adding different values for `kernel-open` option

* Revert "Changing the PATH order we set for using the cfnbootstrap script we have installed in virtualenv rather than using default scripts (#2730)"

This reverts commit 26a3c9d.

---------

Co-authored-by: Himani Deshpande <[email protected]>
Co-authored-by: Enrico Usai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants