[LoginNodes] Add DCV support for login nodes #2780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated `dcv.rb` to activate dcv on the login node. * Updated `supervisord_config` to set `dcv_installed?` to be true when dcv is enabled on a login node. * Updated `parallelcluster_supervisord.conf.erb` to include `pcluster_dcv_authenticator` when dcv is configured on a login node.
This is required to have multiple session files within the shared directory.
* Added `dcv_enabled` attribute to the login node log rotation in `kitchen.platform-config.yml`. * Updated `log_rotation_spec` to include dcv logs for login nodes.
Contributor
|
One of the checks is failing because of cookstyle offenses, you can fix this by running |
hgreebe
approved these changes
Jul 23, 2024
hgreebe
pushed a commit
to hgreebe/aws-parallelcluster-cookbook
that referenced
this pull request
Aug 22, 2024
* Update platform cookbook to support DCV on login nodes * Updated `dcv.rb` to activate dcv on the login node. * Updated `supervisord_config` to set `dcv_installed?` to be true when dcv is enabled on a login node. * Updated `parallelcluster_supervisord.conf.erb` to include `pcluster_dcv_authenticator` when dcv is configured on a login node. * Modify _dcv_common to support DCV on login node * Update cloudwatch config DCV logs to include login nodes * Allow DCV instance metadata access when enabled on login node * Rename the DCV sessionID file to be the instance hostname This is required to have multiple session files within the shared directory. * Update supervisord_config_spec to test DCV on login node * Update kitchen test and spec tests for login node dcv * Added `dcv_enabled` attribute to the login node log rotation in `kitchen.platform-config.yml`. * Updated `log_rotation_spec` to include dcv logs for login nodes. * Update CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
These changes enable DCV on login nodes. A user can now connect to a login node with DCV using
dcv-connectand--login-node-ipparameter.dcv.rbto configure dcv when enabled on login nodes.pcluster_dcv_authenticatoron login nodes.cloudwatch_agent_config.jsonwith login nodedcv_enableddna key.Tests
Manual tests:
ChefSpec + Kitchen
supervisord_config_specto test proper supervisord configuration when dcv is enabled on login nodes.log_rotation_specto test proper log configuration when dcv enabled on login nodes.kitchen.platform-configlog rotation resource.References
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.