Skip to content

test: fix type checks in e2e tests #6075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 8, 2024
Merged

test: fix type checks in e2e tests #6075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4c58fe
test(ec2-metadata-service): fix type checks in e2e tests
trivikr May 8, 2024
1acb33d
test(middleware-sdk-s3): fix type checks in e2e tests
trivikr May 8, 2024
a032eaf
test(s3-presigned-post): fix type checks in e2e tests
trivikr May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/ec2-metadata-service/src/MetadataService.e2e.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ import { fromInstanceMetadata } from "@aws-sdk/credential-providers";
import { MetadataService } from "./MetadataService";

describe("MetadataService E2E Tests", () => {
let metadataService;
let metadataService: any;
const provider = fromInstanceMetadata({ timeout: 1000, maxRetries: 0 });
let metadataServiceAvailable;
let metadataServiceAvailable: any;

beforeAll(async () => {
try {
Expand Down Expand Up @@ -35,7 +35,7 @@ describe("MetadataService E2E Tests", () => {
if (!metadataServiceAvailable) {
return;
}
const metadata = await metadataService.request("/latest/meta-data/", {});
const metadata = (await metadataService.request("/latest/meta-data/", {})) as string;
expect(metadata).toBeDefined();
expect(typeof metadata).toBe("string");
const lines = metadata.split("\n").map((line) => line.trim());
Expand All @@ -49,7 +49,7 @@ describe("MetadataService E2E Tests", () => {
return;
}
metadataService.disableFetchToken = true; // make request without token
const metadata = await metadataService.request("/latest/meta-data/", {});
const metadata = (await metadataService.request("/latest/meta-data/", {})) as string;
expect(metadata).toBeDefined();
expect(typeof metadata).toBe("string");
expect(metadata.length).toBeGreaterThan(0);
Expand All @@ -67,7 +67,7 @@ describe("MetadataService E2E Tests", () => {
throw { name: "TimeoutError" }; // Simulating TimeoutError
});
// Attempt to fetch metadata, expecting IMDSv1 fallback (request without token)
const metadata = await metadataService.request("/latest/meta-data/", {});
const metadata = (await metadataService.request("/latest/meta-data/", {})) as string;
expect(metadata).toBeDefined();
expect(typeof metadata).toBe("string");
const lines = metadata.split("\n").map((line) => line.trim());
Expand All @@ -85,7 +85,7 @@ describe("MetadataService E2E Tests", () => {
jest.spyOn(metadataService, "fetchMetadataToken").mockImplementationOnce(async () => {
throw { statusCode: errorCode };
});
const metadata = await metadataService.request("/latest/meta-data/", {});
const metadata = (await metadataService.request("/latest/meta-data/", {})) as string;
expect(metadata).toBeDefined();
expect(typeof metadata).toBe("string");
const lines = metadata.split("\n").map((line) => line.trim());
Expand Down
2 changes: 2 additions & 0 deletions packages/middleware-sdk-s3/src/s3-express/middleware-s3-express.e2e.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,9 @@ async function createClientAndRecorder() {
const commandName = context.commandName + s3ExpressSuffix;
const input = args.input;
const commandRecorder = (recorder.calls[commandName] = recorder.calls[commandName] ?? {});
// @ts-expect-error Element implicitly has an 'any' type
commandRecorder[input["Bucket"] ?? "-"] |= 0;
// @ts-expect-error Element implicitly has an 'any' type
commandRecorder[input["Bucket"] ?? "-"]++;

return continuation;
Expand Down
2 changes: 1 addition & 1 deletion packages/s3-presigned-post/src/createPresignedPost.e2e.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ describe(createPresignedPost.name, () => {
expect(precheck).toBeInstanceOf(NoSuchKey);

const submit: { statusCode: number } = await new Promise((resolve, reject) => {
form.submit(url, (err, res) => {
form.submit(url, (err: any, res: any) => {
if (err) reject(err);
resolve(res);
});
Expand Down