Skip to content

Conversation

@kuhe
Copy link
Contributor

@kuhe kuhe commented Oct 20, 2025

Issue

#7439

Description

propagate clientConfig to inner STS client

Testing

  • new integration tests
  • CI

Checklist

  • If the PR is a feature, add integration tests (*.integ.spec.ts).
  • If you wrote E2E tests, are they resilient to concurrent I/O?
  • If adding new public functions, did you add the @public tag and enable doc generation on the package?

@kuhe kuhe force-pushed the fix-nested-sts-configuration branch from 12d91d2 to 377debb Compare October 20, 2025 20:22
@jackrein
Copy link
Contributor

Will it be necessary to set both the parent client and the credentials provider clientConfig? The comment in the docs states that region and profile will be propagated, but nothing else.

new S3Client({
    customUserAgent: [["custom-user-agent", "1.0.0"]],
    credentials: fromNodeProviderChain({
        clientConfig: {
            customUserAgent: [["custom-user-agent", "1.0.0"]],
        }
    })
});

@kuhe
Copy link
Contributor Author

kuhe commented Oct 21, 2025

Yes, setting a user agent value on the both outer and inner client configs will be required even after this change is published.

@kuhe kuhe merged commit 6ec7126 into main Oct 21, 2025
8 checks passed
@kuhe kuhe deleted the fix-nested-sts-configuration branch October 23, 2025 17:40
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants