chore: add 8.5 support #3179
Open
chore: add 8.5 support #3179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stobrien89
force-pushed
the
8.5-support
branch
25 times, most recently
from
db0f8a3 to
fc5c30c
Compare
stobrien89
force-pushed
the
8.5-support
branch
from
fc5c30c to
116c59b
Compare
| "ext-openssl": "Allows working with CloudFront private distributions and verifying received SNS messages", | ||
| "ext-curl": "To send requests using cURL", | ||
| "ext-sockets": "To use client-side monitoring", | ||
| "ext-pcntl": "*", |
There was a problem hiding this comment.
Incorrect syntax. The value is meant to be a reason to the user why the package is needed.
There was a problem hiding this comment.
Yes- thank you for the reminder. I just copy/pasted into suggest while I was working on the Windows workflows. I had intended to change this, but probably would have forgotten.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds 8.5 to the tests workflow version matrix.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.