Fix to execute efa tests on mainline #1083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SM local tests are passing now and SM remote tests are running |
jeet4320
commented
Apr 30, 2021
| f"pytest -rA {integration_path} --region {region} --processor {processor} {docker_base_arg} " | ||
| f"{sm_remote_docker_base_name} --tag {tag} {framework_version_arg} {framework_version} " | ||
| f"{aws_id_arg} {account_id} {instance_type_arg} {instance_type} --junitxml {test_report}" | ||
| f"{aws_id_arg} {account_id} {instance_type_arg} {instance_type} {efa_flag} --junitxml {test_report}" |
There was a problem hiding this comment.
efa is just needed for SM training remote tests
jeet4320
commented
Apr 30, 2021
| parser.addoption('--tag', default=None) | ||
| parser.addoption('--generate-coverage-doc', default=False, action='store_true', | ||
| help='use this option to generate test coverage doc') | ||
| parser.addoption( |
There was a problem hiding this comment.
this was added for local SM tests, but we dont have EFA for local SM tests
tejaschumbalkar
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
PR Checklist
Pytest Marker Checklist
@pytest.mark.model("<model-type>")to the new tests which I have added, to specify the Deep Learning model that is used in the test (use"N/A"if the test doesn't use a model)@pytest.mark.integration("<feature-being-tested>")to the new tests which I have added, to specify the feature that will be tested@pytest.mark.multinode(<integer-num-nodes>)to the new tests which I have added, to specify the number of nodes used on a multi-node test@pytest.mark.processor(<"cpu"/"gpu"/"eia"/"neuron">)to the new tests which I have added, if a test is specifically applicable to only one processor typeEIA/NEURON Checklist
src/config/build_config.pyin my PR branch by settingENABLE_EI_MODE = TrueorENABLE_NEURON_MODE = TrueBenchmark Checklist
src/config/test_config.pyin my PR branch by settingENABLE_BENCHMARK_DEV_MODE = TrueReviewer Checklist
Description:
Tests run:
DLC image/dockerfile:
Additional context:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.