NTH - Add CORDON_ONLY and METADATA_TRIES to daemonset template #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NTH change: aws/aws-node-termination-handler#145 |
|
Closing in favor of doing these changes within #123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add the options for metadata tries and cordon only to the daemonset helm chart. metadata tries is an option that's been present in NTH that we forgot to add here. cordon only is a new option related to an upcoming PR for NTH issue aws/aws-node-termination-handler#135
I'll add the related NTH PR here once I create it, shouldn't take much time, I just wanted to create this one first to avoid failing the build in NTH.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.