Skip to content

Update telemetry status to be Integer for parity #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025
Merged

Update telemetry status to be Integer for parity #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/sagemaker/hyperpod/common/telemetry/telemetry_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ def wrapper(*args, **kwargs):
duration = round(perf_counter() - start, 2)
extra += f"&x-latency={duration}"
_send_telemetry_request(
Status.SUCCESS,
STATUS_TO_CODE[str(Status.SUCCESS)],
[FEATURE_TO_CODE[str(feature)]],
None,
None,
Expand All @@ -172,7 +172,7 @@ def wrapper(*args, **kwargs):
duration = round(perf_counter() - start, 2)
extra += f"&x-latency={duration}"
_send_telemetry_request(
Status.FAILURE,
STATUS_TO_CODE[str(Status.FAILURE)],
[FEATURE_TO_CODE[str(feature)]],
None,
str(e),
Expand Down
8 changes: 5 additions & 3 deletions test/unit_tests/common/telemetry/test_telemetry_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
import requests
import logging

from src.sagemaker.hyperpod.common.telemetry.telemetry_logging import STATUS_TO_CODE

# Test data
MOCK_CONTEXTS = {
"eks_arn": "arn:aws:eks:us-west-2:123456789012:cluster/my-cluster",
Expand Down Expand Up @@ -163,7 +165,7 @@ def sample_function():
args = mock_telemetry.call_args[0]

# Check status
assert args[0] == Status.SUCCESS
assert args[0] == STATUS_TO_CODE[str(Status.SUCCESS)]

# Check feature code
assert args[1] == [FEATURE_TO_CODE[str(Feature.HYPERPOD)]]
Expand Down Expand Up @@ -198,11 +200,11 @@ def sample_function(succeed: bool):

# Check success call
success_call = mock_telemetry.call_args_list[0]
assert success_call[0][0] == Status.SUCCESS
assert success_call[0][0] == STATUS_TO_CODE[str(Status.SUCCESS)]

# Check failure call
failure_call = mock_telemetry.call_args_list[1]
assert failure_call[0][0] == Status.FAILURE
assert failure_call[0][0] == STATUS_TO_CODE[str(Status.FAILURE)]


# Test _requests_helper
Expand Down
Loading