Skip to content

Small bug fix to print debug messages for inference logger (PySDK) #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 8, 2025
Merged

Small bug fix to print debug messages for inference logger (PySDK) #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
64e54a1
Draft of inference logger bug fix
aviruthen Aug 26, 2025
9029948
Draft fix of inference logger for SDK
aviruthen Aug 26, 2025
d182821
Revert adding --debug flag
aviruthen Aug 27, 2025
1078d86
Add debug parameter to failing unit tests
aviruthen Aug 27, 2025
b9c9da1
Fix create_from_dict to not have hardcoded debug flag
aviruthen Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/sagemaker/hyperpod/inference/hp_endpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ def create(
kind=INFERENCE_ENDPOINT_CONFIG_KIND,
namespace=namespace,
spec=spec,
debug=debug,
)

self.metadata = Metadata(
Expand All @@ -71,9 +72,10 @@ def create_from_dict(
input: Dict,
name: str = None,
namespace: str = None,
debug=False
) -> None:
logger = self.get_logger()
logger = setup_logging(logger)
logger = setup_logging(logger, debug)

spec = _HPEndpoint.model_validate(input, by_name=True)

Expand All @@ -93,6 +95,7 @@ def create_from_dict(
kind=INFERENCE_ENDPOINT_CONFIG_KIND,
namespace=namespace,
spec=spec,
debug=debug,
)

self.metadata = Metadata(
Expand Down
3 changes: 2 additions & 1 deletion src/sagemaker/hyperpod/inference/hp_endpoint_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ def call_create_api(
kind: str,
namespace: str,
spec: Union[_HPJumpStartEndpoint, _HPEndpoint],
debug: bool = False,
):
"""Create an inference endpoint using Kubernetes API.

Expand Down Expand Up @@ -104,7 +105,7 @@ def call_create_api(
cls.verify_kube_config()

logger = cls.get_logger()
logger = setup_logging(logger)
logger = setup_logging(logger, debug)

custom_api = client.CustomObjectsApi()

Expand Down
5 changes: 4 additions & 1 deletion src/sagemaker/hyperpod/inference/hp_jumpstart_endpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ def create(
kind=JUMPSTART_MODEL_KIND,
namespace=namespace,
spec=spec,
debug=debug,
)

self.metadata = Metadata(
Expand All @@ -76,9 +77,10 @@ def create_from_dict(
input: Dict,
name: str = None,
namespace: str = None,
debug = False
) -> None:
logger = self.get_logger()
logger = setup_logging(logger)
logger = setup_logging(logger, debug)

spec = _HPJumpStartEndpoint.model_validate(input, by_name=True)

Expand All @@ -102,6 +104,7 @@ def create_from_dict(
kind=JUMPSTART_MODEL_KIND,
namespace=namespace,
spec=spec,
debug=debug,
)

self.metadata = Metadata(
Expand Down
9 changes: 8 additions & 1 deletion test/unit_tests/inference/test_hp_endpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ def test_create(self, mock_create_api, mock_validate_instance_type):
kind=INFERENCE_ENDPOINT_CONFIG_KIND,
namespace="test-ns",
spec=unittest.mock.ANY,
debug=False,
)
self.assertEqual(self.endpoint.metadata.name, "test-name")

Expand All @@ -115,7 +116,13 @@ def test_create_from_dict(self, mock_create_api, mock_validate_instance_type):

self.endpoint.create_from_dict(input_dict, namespace="test-ns")

mock_create_api.assert_called_once()
mock_create_api.assert_called_once_with(
name=unittest.mock.ANY,
kind=INFERENCE_ENDPOINT_CONFIG_KIND,
namespace="test-ns",
spec=unittest.mock.ANY,
debug=False,
)

@patch.object(HPEndpoint, "call_get_api")
def test_refresh(self, mock_get_api):
Expand Down
9 changes: 8 additions & 1 deletion test/unit_tests/inference/test_hp_jumpstart_endpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ def test_create(self, mock_create_api, mock_validate_instance_type):
kind=JUMPSTART_MODEL_KIND,
namespace="test-ns",
spec=unittest.mock.ANY,
debug=False,
)
self.assertEqual(self.endpoint.metadata.name, "test-name")

Expand All @@ -60,7 +61,13 @@ def test_create_from_dict(self, mock_create_api, mock_validate_instance_type):
input_dict, name="test-name", namespace="test-ns"
)

mock_create_api.assert_called_once()
mock_create_api.assert_called_once_with(
name="test-name",
kind=JUMPSTART_MODEL_KIND,
namespace="test-ns",
spec=unittest.mock.ANY,
debug=False,
)

@patch.object(HPJumpStartEndpoint, "call_get_api")
def test_refresh(self, mock_get_api):
Expand Down