Skip to content

Code Coverage for Integ Tests #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 11, 2025
Merged

Code Coverage for Integ Tests #262

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2c4f8e
Code Coverage for Integ Tests
aviruthen Sep 11, 2025
93bbd2b
Making sure target of coverage is correct
aviruthen Sep 11, 2025
a5076d9
Removing duplicate implementation
aviruthen Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ xfail_strict = true
addopts =
--verbose
--ignore=build/private
--cov hyperpod_cli
--cov sagemaker.hyperpod
--cov-config setup.cfg
--cov-report term-missing
--cov-report html:build/hyperpod-documentation/coverage
Expand All @@ -59,8 +59,8 @@ addopts =
--durations=5
# Default to colorful output
--color=yes
# Uncomment to enforce a minimum code coverage threshold.
# --cov-fail-under 50
# Enforce a minimum code coverage threshold
--cov-fail-under 50
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why threshold is just 50 ? whats the current coverage for integ tests ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned in slack channel, but for visibility for reviewers, current coverage is 55%. If we remove files that are not important to test with integ tests (static data definitions, basic utils, etc.) the new code coverage is estimated at 67%. We can raise threshold as more tests are added, but raising it much higher than 50% will become a blocker for PRs

testpaths = test
looponfailroots = src test

Expand Down
Loading