Update cluster creation template url with versioning #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
aviruthen
approved these changes
Oct 7, 2025
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
aviruthen
reviewed
Oct 8, 2025
| # Set fixed defaults | ||
| defaults = { | ||
| 'custom_bucket_name': 'sagemaker-hyperpod-cluster-stack-bucket', | ||
| 'custom_bucket_name': 'aws-sagemaker-hyperpod-cluster-setup', |
There was a problem hiding this comment.
Do you want to set this also to be the empty string as a default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing and why?
Update S3 url of cluster creation template with versioning.
Before/After UX
Before:
hyp create --region us-east-2After:
User has a new optional parameter
template-versionhyp create --region us-east-2 --template-version 1How was this change tested?
hyp init cluster-stackhyp create --region us-east-2 --template-version 1Are unit tests added?
Updated existing unit tests with this new parameter
Are integration tests added?
Updated existing integ tests with this new parameter
Reviewer Guidelines
One of the following must be true: