Skip to content

Conversation

@laurenyu
Copy link
Contributor

Issue #, if available:
#388

Description of changes:
cherry-picking #389 for the tf-2 branch

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-training-container-pr
  • Commit ID: e6ea70d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-training-gpu
  • Commit ID: e6ea70d
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-tensorflow-training-toolkit-pr
  • Commit ID: e6ea70d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@metrizable metrizable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@laurenyu laurenyu merged commit 92e232d into aws:tf-2 Jun 17, 2020
Copy link
Contributor

@nadiaya nadiaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure local mode + horovod tests actually add enough value considering how slow they are and that they require really big boxes.
Not sure local-mode + horovod is a real customer use case + local mode distributed training is a simulation so we don''t really tests that much in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants