Skip to content

Conversation

@philcali
Copy link
Contributor

Issue #, if available:

The V2 request object would not use the cookies field in the 2.0 schema. It would default to an empty array. See https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-develop-integrations-lambda.html for raw input details.

Description of changes:

This change first checks of the cookies field is set on the underlying request POJO and will use that instead.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@deki deki changed the base branch from master to dev July 22, 2021 13:06
@deki deki merged commit d1a396f into aws:dev Jul 22, 2021
@deki
Copy link
Contributor

deki commented Jul 22, 2021

Thanks for your contribution, @philcali

@deki
Copy link
Contributor

deki commented Jul 22, 2021

@philcali I just noticed there are two test failures after this change. Can you take a look please?

cookie_getCookies_multipleCookies2: Cookie name " test_cookie_param" is a reserved token
cookie_getCookies_emptyCookies2: Index 1 out of bounds for length 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants