Skip to content

Conversation

Neves97
Copy link
Contributor

@Neves97 Neves97 commented Jan 23, 2024

Fixed missing maven references on Pet-Store sample project

<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<version>3.5.1</version>
<version>3.5.0</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to downgrade or were you facing any issues with the latest version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.5.0 Was being marked as not found, so I downgraded to the suggested version.
Plugin 'org.apache.maven.plugins:maven-shade-plugin:3.5.1' not found

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to build just fine though, but the warning does not go away.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe related to your local cache? It's available in central: https://repo1.maven.org/maven2/org/apache/maven/plugins/maven-shade-plugin/3.5.1/
Can you please remove the change from the PR? I will merge afterwards. Thanks.

@deki deki merged commit 1b4a659 into aws:main Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants