Fix cmake script to respect the CMAKE_INSTALL_LIBDIR / CMAKE_INSTALL_BINDIR settings for all platforms #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The build file was setting LIBRARY_DIRECTORY and RUNTIME_DIRECTORY to defaults, and then overwrote the defaults with the values of CMAKE_INSTALL_LIBDIR / CMAKE_INSTALL_BINDIR only for UNIX non-Apple builds, and regardless of whether or not those values were set.
This change sets the LIBRARY_DIRECTORY / RUNTIME_DIRECTORY values to use CMAKE_INSTALL_LIBDIR / CMAKE_INSTALL_BINDIR for all platforms, unless the value doesn't exist, at which point it uses the default.
NOTE: I will also submit an identical change to aws-checksums, which has the same error.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.