macOS Final Pass #766
macOS Final Pass #766
Conversation
sbSteveK
changed the base branch from
main
to
macos-secitem/filebased-keychain
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## macos-secitem/filebased-keychain #766 +/- ##
=================================================================
Coverage 78.76% 78.76%
=================================================================
Files 30 30
Lines 6410 6410
=================================================================
Hits 5049 5049
Misses 1361 1361 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sfod
force-pushed
the
macos-final-changes
branch
from
f9683bb to
ae24752
Compare
source/darwin/darwin_pki_utils.c
Outdated
| } | ||
| } | ||
|
|
||
| #if !defined(AWS_OS_IOS) |
There was a problem hiding this comment.
Two comments:
1 - Should this also include tvOS?
2 - I think we're moving away from having platform specific build paths and functions. Unless there's a case against it, maybe we can put the split within the function itself. e.g. if iOS/tvOS return a platform not supported error or some other logging.
There was a problem hiding this comment.
Good catch, the check should be for macos only.
As for the second point, I think the SecKeychain functions may cause compile-time issues for ios/tvos. And beside that, it's a private function, so maybe wrap a call to it into ifdef?
4 participants
Final Pass to get macOS branch ready for merge.
Primarily consists of removing any iOS, Apple Network Framework, or Secitem specific branching and using APPLE as everything on apple will use both network framework and secitem now. Old Security Framework used by macOS before the migration has also been cleaned up.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.