Cmake modules #702
Merged
Cmake modules #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
further comments here: awslabs/aws-c-common@82dc7af
1 task
graebm
approved these changes
Jan 30, 2025
Contributor
graebm
left a comment
graebm
left a comment
There was a problem hiding this comment.
Do a minor version bump when this is released: to v0.30.0
The other aws-crt-*** libs don't need that, but c++ does
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply bunch of CMake fixes.
See: awslabs/aws-c-common#1178
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.