Skip to content

Change examples to use tracing-subscriber for logging #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2022
Merged

Change examples to use tracing-subscriber for logging #389

merged 1 commit into from
Jan 6, 2022

Conversation

@bahildebrand
Copy link
Contributor

@bahildebrand bahildebrand commented Dec 31, 2021

Description of changes:
Update examples to use tracing-subscriber to be more in line with with usage inside library.

By submitting this pull request

  • [x ] I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • [ x] I confirm that I've made a best effort attempt to update all relevant documentation.

@bahildebrand
Copy link
Contributor Author

bahildebrand commented Dec 31, 2021

Note that clippy failure is solved in #388

nmoutschen
nmoutschen approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@nmoutschen nmoutschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

calavera
calavera approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calavera calavera merged commit 5e324ae into awslabs:master Jan 6, 2022
@calavera calavera mentioned this pull request Jan 6, 2022
Closed
2 tasks
@nmoutschen nmoutschen added the 0.5 label Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@calavera calavera calavera approved these changes

@nmoutschen nmoutschen nmoutschen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

0.5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bahildebrand @calavera @nmoutschen