Skip to content

Conversation

@greenwoodcm
Copy link
Contributor

this just copies the code across examples so that we're initializing the tracing subscriber in a consistent way. we want to set a max level, disable printing the name of the module every time, disable ANSI color codes (because CloudWatch prints them in a non-readable way), and disable logging the time at this layer because CloudWatch is going to add the ingestion time itself.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

this just copies the code across examples so that we're initializing
the tracing subscriber in a consistent way.  we want to set a max
level, disable printing the name of the module every time, disable
ANSI color codes (because CloudWatch prints them in a non-readable
way), and disable logging the time at this layer because CloudWatch
is going to add the ingestion time itself.
Copy link
Contributor

@bnusunny bnusunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greenwoodcm greenwoodcm merged commit 847b060 into awslabs:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants