Modify distributed_training_utils.py import for TF 2.4 #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #422 +/- ##
==========================================
- Coverage 77.03% 75.14% -1.90%
==========================================
Files 113 113
Lines 10165 10169 +4
==========================================
- Hits 7831 7641 -190
- Misses 2334 2528 +194
Continue to review full report at Codecov.
|
| from tensorflow.python.keras.distribute.distributed_training_utils import ( | ||
| get_distributed_model, | ||
| ) | ||
| if is_tf_version_greater_than_2_4_x(): |
There was a problem hiding this comment.
Can we replace this function from utils with the function defined here to reduce code redundancy?
ndodda-amazon
suggested changes
Jan 13, 2021
ndodda-amazon
approved these changes
Jan 13, 2021
sophiayue1116
pushed a commit
to sophiayue1116/sagemaker-debugger
that referenced
this pull request
Jan 20, 2021
sophiayue1116
pushed a commit
to sophiayue1116/sagemaker-debugger
that referenced
this pull request
Jan 20, 2021
sophiayue1116
pushed a commit
to sophiayue1116/sagemaker-debugger
that referenced
this pull request
Jan 20, 2021
sophiayue1116
pushed a commit
to sophiayue1116/sagemaker-debugger
that referenced
this pull request
Jan 20, 2021
sophiayue1116
pushed a commit
to sophiayue1116/sagemaker-debugger
that referenced
this pull request
Jan 20, 2021
sophiayue1116
pushed a commit
to sophiayue1116/sagemaker-debugger
that referenced
this pull request
Jan 22, 2021
sophiayue1116
pushed a commit
to sophiayue1116/sagemaker-debugger
that referenced
this pull request
Jan 22, 2021
NihalHarish
added a commit
that referenced
this pull request
Jan 25, 2021
sophiayue1116
pushed a commit
to sophiayue1116/sagemaker-debugger
that referenced
this pull request
Jan 29, 2021
sophiayue1116
pushed a commit
to sophiayue1116/sagemaker-debugger
that referenced
this pull request
Jan 29, 2021
sophiayue1116
pushed a commit
to sophiayue1116/sagemaker-debugger
that referenced
this pull request
Jan 29, 2021
sophiayue1116
pushed a commit
to sophiayue1116/sagemaker-debugger
that referenced
this pull request
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Style and formatting:
I have run
pre-commit installto ensure that auto-formatting happens with every commit.Issue number, if available
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.