Skip to content

Conversation

@ndodda-amazon
Copy link
Contributor

Description of changes:

Two major changes:

  • Fixed a bug with actions where the message was not correctly passed (so SNS notifications would always send a message of None)
  • Improved design so that all rules should either support actions or explicitly not support actions (by simply passing an action_str of ""). Going forward, if we create new rules, we won't forget to support actions.

Style and formatting:

I have run pre-commit install to ensure that auto-formatting happens with every commit.

Issue number, if available

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Feb 18, 2021

Codecov Report

Merging #448 (a79560d) into master (64fb95f) will increase coverage by 0.09%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
+ Coverage   65.73%   65.83%   +0.09%     
==========================================
  Files         161      161              
  Lines       12749    12747       -2     
==========================================
+ Hits         8381     8392      +11     
+ Misses       4368     4355      -13     
Impacted Files Coverage Δ
smdebug/rules/action/stop_training_action.py 54.68% <50.00%> (+0.14%) ⬆️
smdebug/rules/action/action.py 91.83% <100.00%> (ø)
smdebug/rules/action/message_action.py 81.92% <100.00%> (ø)
smdebug/rules/rule.py 84.84% <100.00%> (ø)
smdebug/core/reduction_config.py 88.31% <0.00%> (-2.60%) ⬇️
smdebug/core/save_config.py 88.80% <0.00%> (+0.79%) ⬆️
smdebug/core/writer.py 90.09% <0.00%> (+4.50%) ⬆️
smdebug/core/logger.py 76.38% <0.00%> (+5.55%) ⬆️
smdebug/core/tfevent/summary.py 88.13% <0.00%> (+6.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64fb95f...a79560d. Read the comment docs.

@ndodda-amazon ndodda-amazon merged commit 3dd15a3 into master Feb 19, 2021
@ndodda-amazon ndodda-amazon deleted the fix_actions_bug branch February 19, 2021 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants