Pin mxnet version for vanilla tests #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndodda-amazon
suggested changes
Mar 22, 2021
There was a problem hiding this comment.
LGTM, left a minor comment.
On the other hand, if we don't have a long term solution for testing open source frameworks, should we temporarily disable running these tests in our pipelines? Doesn't seem like a good idea to have one build running tests for all frameworks anyway.
| - cd $CODEBUILD_SRC_DIR && chmod +x config/protoc_downloader.sh && ./config/protoc_downloader.sh | ||
| - pip install --upgrade pip==20.3.3 | ||
| - pip install -q -U pytest pytest-cov wheel pyYaml pytest-html keras==2.3.1 mxnet torch xgboost pre-commit tensorflow_datasets==4.0.1 torchvision | ||
| - pip install -q -U pytest pytest-cov wheel pyYaml pytest-html keras==2.3.1 mxnet==1.6.0 torch xgboost pre-commit tensorflow_datasets==4.0.1 torchvision |
There was a problem hiding this comment.
Let's pin the versions to the other frameworks too.
Codecov Report
@@ Coverage Diff @@
## master #468 +/- ##
==========================================
- Coverage 65.55% 65.22% -0.33%
==========================================
Files 173 163 -10
Lines 13275 12929 -346
==========================================
- Hits 8702 8433 -269
+ Misses 4573 4496 -77
Continue to review full report at Codecov.
|
ndodda-amazon
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Style and formatting:
I have run
pre-commit installto ensure that auto-formatting happens with every commit.Issue number, if available
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.