Skip to content

Remove compat method #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Remove compat method #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions smdebug/core/hook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,11 +246,6 @@ def create_from_json_file(cls, json_file_path=None):
"""
return create_hook_from_json_config(cls, json_config_path=json_file_path)

# For compatibility purposes only; do not use
@classmethod
def hook_from_config(cls, json_config_path=None):
return cls.create_from_json_file(json_file_path=json_config_path)

@abstractmethod
def _get_worker_name(self):
pass
Expand Down
5 changes: 5 additions & 0 deletions smdebug/xgboost/hook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,11 @@ def create_from_json_file(cls, json_file_path=None):
cls, json_config_path=json_file_path, default_values=default_values
)

# For compatibility purposes only; do not use
@classmethod
def hook_from_config(cls, json_config_path=None):
return cls.create_from_json_file(json_file_path=json_config_path)

def _is_last_step(self, env: CallbackEnv) -> bool:
# env.iteration: current boosting round.
# env.end_iteration: round # when training will end. this is always num_round + 1. # noqa: E501
Expand Down