feat(ai): add evaluation API reporting #91
Draft
+193
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
thesollyz
reviewed
Sep 30, 2025
packages/ai/src/evals/eval.ts
Outdated
| }); | ||
|
|
||
| afterAll(async (suite) => { | ||
| console.log('afterAll'); |
There was a problem hiding this comment.
Suggested change
| console.log('afterAll'); |
thesollyz
reviewed
Sep 30, 2025
packages/ai/src/evals/eval.ts
Outdated
| successCases, | ||
| erroredCases, | ||
| durationMs, | ||
| scorers: scorerNames, |
There was a problem hiding this comment.
scorers names could be collected during initialization of the evaluation, I think it doesn't needed to be part of the patch request.
thesollyz
reviewed
Sep 30, 2025
packages/ai/src/evals/eval.ts
Outdated
|
|
||
| type EvaluationStatus = 'running' | 'completed' | 'errored' | 'cancelled'; | ||
|
|
||
| const postCreateEvaluation = async (payload: CreateEvaluationPayload): Promise<Response | null> => { |
There was a problem hiding this comment.
We could extract the API calls to Axiom into a separate service file, there is already eval.service.ts, we can use it.
…e evaluation creation logic
c-ehrlich
reviewed
Oct 1, 2025
| // aggregate success and scores | ||
| successCases++; | ||
| for (const s of scoreList) { | ||
| const value = Number((s as unknown as { score: number }).score); |
There was a problem hiding this comment.
thesollyz
reviewed
Oct 1, 2025
| let evalId = ''; // get traceId | ||
| let anyCaseFailed = false; | ||
| const suiteStart = performance.now(); | ||
| let successCases = 0; |
There was a problem hiding this comment.
in afterAll() we have access to the suite along with its children, I would say its safer to loop over the suite tasks and check state of each instead of counting them this way.
Another q: are these numbers going to be used in the UI?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.