📏 Report binary size on PR #2
Conversation
bdeneux
force-pushed
the
feat/binary-size
branch
6 times, most recently
from
63641bc to
c64283c
Compare
|
Blocked by andresz1/size-limit-action#30 (comment) |
size-limit report 📦
|
|
It's working ! Just by adding a RUSTFLAGS at the compilation time (like cosmwasm documentation said), the wasm binary decrease by 90% 😍. |
ccamel
left a comment
ccamel
left a comment
There was a problem hiding this comment.
Great initiative! ❤️
Some remarks we can discuss.
And just a point of detail about this commit: feat: add binary size action. It should be prefixed with "ci:" like you did for the others. 😛
bdeneux
force-pushed
the
feat/binary-size
branch
from
f1a43af to
2df21cd
Compare
About this commit, I've removed it instead of rename since it was a try of another GitHub action |
bdeneux
force-pushed
the
feat/binary-size
branch
3 times, most recently
from
fba5bde to
e005a95
Compare
amimart
left a comment
amimart
left a comment
There was a problem hiding this comment.
That's a very relevant idea, thank you 👍 .
I'll have some little suggestions though
bdeneux
force-pushed
the
feat/binary-size
branch
from
21008a1 to
784e3ba
Compare
|
Thanks for the work! Let's merge it. |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
📝 Description
Given that the size of a smart contract is very important and that it has a very strong impact on transaction costs, it seemed to me necessary to add a small action allowing to report the evolution of the size of each smart contract binary wasm.
🛠 Tool
The tool used here is size-limit-action in addition to size-limit javascript tool. It's the only github action always maintained that allowing report file size evolution into a PR comment. Cargo-bloat also exist but is not compatible with wasm target.
A limitation can be set for each file and make the PR failed if the file size exceed the limit.
🐛 Issues
package.json😭😭, sincesize-limitis a JS tool, to make this action work, I need to add apackage.json file. So to avoid pollute rust with JS stuff, I've add thepackage.jsonfile setting into the GitHub action.size-limitneeds a configuration file to set which file it should analyse. But for the first PR, the config file doesn't exist into the main branch, so the action failed (for comparaison with the main branch of course,size-limitneed to build on it). A temporary solution is to add the configuration file into thepackage.jsoninto the GitHub action, it's working but I prefer set the configuration into a specific file.size-limit. Sincepackage.jsonsize-limitconfiguration is priority, we need after this PR merged, remove the configuration frompackage.json.