-
Notifications
You must be signed in to change notification settings - Fork 40
Open
backdrop/backdrop
#5161Labels
Description
Description of the bug
node_page_view uses $node->title instead of $node->label() to call backdrop_set_title. In modules that use non-standard translation, such as the entity_translation and title modules that define a label callback the issue is that node titles get cached and end up setting the title to a cached value rather than
Steps To Reproduce
This is pretty annoying to do.
To reproduce the behavior:
- Turn on entity_translation
- Turn on title module (which allows properties such as titles to be translated)
- Go to the node type you want to enable translation for
- Enable the title module
- Create a node in your default language
- Create a node in another language
- Make sure caching is turned on
- Go to view the node in one language and make sure you get a cache hit
- Go to view the node in a different language
- The browser tab title will show in the original language, not the current language.
Actual behavior
The tab title is in the wrong language
Expected behavior
The tab title should be in the current language.
Additional information
Using $node->label() instead of $node->title fixes the problem. Patch incoming.