Governance V2 #146
Governance V2 #146
Conversation
AnnaShaleva
left a comment
AnnaShaleva
left a comment
There was a problem hiding this comment.
Just a set of quick thoughts, will properly review the contract later.
contracts/solidity/GovRewardV2.sol
Outdated
| } | ||
|
|
||
| function withdraw() external onlyGov { | ||
| TransferHelper.safeTransferETH(governance, address(this).balance); |
There was a problem hiding this comment.
We send reward to Governance Proxy contract, and then Governance Proxy contract will send reward to Governance implementation contract with subsequent receive() method call. So as a result the final destination of reward funds is Governance implementation contract (not a Proxy), right?
There was a problem hiding this comment.
No, the receive() of Proxy contract will fall back to implement contract with delegate call. Please refer to https://github.com/OpenZeppelin/openzeppelin-contracts/blob/release-v3.4/contracts/proxy/Proxy.sol and
https://solidity-by-example.org/delegatecall.
| (msg.value * shareRateOf[validators[i]] * scaleFactor) / | ||
| consensusSize / | ||
| 1000 / |
There was a problem hiding this comment.
We should create at least basic documentation for reward calculations to show it to users. It should be documented that:
shareRateOfis X/1000, otherwise it's not clear- register fee amount
- minimum vote amount
- locking period for candidate registration fee
- etc.
Do we need a separate issue for documentation?
Co-authored-by: Anna Shaleva <[email protected]>
|
I've tried different settings for compilation (refer to Optimizer Parameter Runs), and finally set it Well, maybe someone who knows the reason can leave a comment. |
|
Let's move further comments back to #7. |
Governance.solandGovReward.solhave a V2, others remain compatible.