Add Throwable exception catch #1432
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfn
reviewed
Mar 24, 2023
src/Alias.php
Outdated
Comment on lines
304
to
307
| } catch (\Exception $e) { | ||
| $this->error('Exception: ' . $e->getMessage() . "\nSkipping $facade."); | ||
| } catch (\Throwable $e) { | ||
| $this->error('Throwable: ' . $e->getMessage() . "\nSkipping $facade."); |
Collaborator
There was a problem hiding this comment.
I'm fine just catching Throwable here; no need/benefit for both
mfn
approved these changes
Mar 24, 2023
Collaborator
|
ps: re-requested review from @barryvdh , I don't think this is controversial and sure looks like a good idea and we should just merge it :) |
Collaborator
|
hmm |
Owner
|
I cannot do that anymore. is it is deleted. |
Collaborator
|
ah ok, head repo was deleted 🤷🏼 |
Collaborator
|
Redid PR in #1465 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #1431
Type of change