Skip to content

reth: rename “vanilla” to “OP Reth”; align README terminology #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 8, 2025
Merged

reth: rename “vanilla” to “OP Reth”; align README terminology #547

merged 5 commits into from
Oct 8, 2025
+4 −4

Conversation

Forostovec
Copy link
Contributor

  • Change entrypoint log to “Starting OP Reth node”
  • Clarify NODE_TYPE=vanilla = OP Reth (Optimism fork)
  • Update intro and run command wording in reth/README.md

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Sep 22, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

danyalprout
danyalprout requested changes Oct 8, 2025
View reviewed changes
Copy link
Collaborator

@danyalprout danyalprout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, lets remove the Optimism fork quote though as it's technically not a fork

@danyalprout danyalprout self-requested a review October 8, 2025 18:09
@cb-heimdall
Copy link
Collaborator

Review Error for danyalprout @ 2025-10-08 18:09:12 UTC
User cannot review their own commit

@danyalprout danyalprout merged commit b844ef5 into base:main Oct 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyalprout danyalprout danyalprout approved these changes

@cody-wang-cb cody-wang-cb cody-wang-cb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Forostovec @cb-heimdall @danyalprout @cody-wang-cb