Add dt_patches/compiler_sources repo #1654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of the Bzlmod prep work from bazel-contrib#1482, but also reduces duplication between the `dt_patches/test_dt_patches*/WORKSPACE` files. The structure of the `dt_patches/compiler_sources/extensions.bzl` declarations accommodates the fact that, unlike `WORKSPACE, `MODULE.bazel` files cannot import constants or contain conditional statements. That is to say, there's no way to port the `if SCALA_VERSION.startswith("2.")` expressions from the previous `WORKSPACE` files to Bzlmod. The new `import_compiler_source_repos` macro, however, works for both `WORKSPACE` and Bzlmod builds, as it's trivial to wrap `import_compiler_source_repos` in a module extension.
This was referenced Dec 2, 2024
simuons
approved these changes
Dec 4, 2024
liucijus
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces the
dt_patches/compiler_sourcesrepo. This is part of the Bzlmod prep work from #1482, but also reduces duplication between thedt_patches/test_dt_patches*/WORKSPACEfiles.Motivation
The structure of the
dt_patches/compiler_sources/extensions.bzldeclarations accommodates the fact that, unlikeWORKSPACE,MODULE.bazelfiles cannot import constants or contain conditional statements. That is to say, there's no way to port theif SCALA_VERSION.startswith("2.")expressions from the previousWORKSPACEfiles toMODULE.bazel`.The new
import_compiler_source_reposmacro, however, works for bothWORKSPACEand Bzlmod builds, as it's trivial to wrapimport_compiler_source_reposin a module extension.